rustc: Lint against #[macro_use] in 2018 idioms
#52275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc |
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
lgtm @bors: r+ |
|
📌 Commit 7ac345a04c86381b929343195c56839350898e1b has been approved by |
bors
added
S-waiting-on-bors
alexcrichton
force-pushed
the
no-macro-use
branch
from
7ac345a to
c48e5a0
Compare
|
@bors: r=nrc |
|
📌 Commit c48e5a0d948e4f276953a2fd31cd6d8b33b3efbe has been approved by |
This comment has been minimized.
This comment has been minimized.
alexcrichton
force-pushed
the
no-macro-use
branch
from
c48e5a0 to
1b32f92
Compare
|
@bors: r=nrc |
|
📌 Commit 1b32f920655284fa5e2e8cc3b1d938adb8b93722 has been approved by |
This comment has been minimized.
This comment has been minimized.
This commit adds a lint to the compiler to warn against the `#[macro_use]` directive as part of the `rust_2018_idioms` lint. This lint is turned off by default and is only enabled when the `use_extern_macros` feature is also enabled. The lint here isn't fully fleshed out as it's just a simple warning rather than suggestions of how to actually import the macro, but hopefully it's a good base to start from! cc rust-lang#52043
alexcrichton
force-pushed
the
no-macro-use
branch
from
1b32f92 to
0b969a9
Compare
|
@bors: r=nrc |
|
📌 Commit 0b969a9 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 13, 2018
rustc: Lint against `#[macro_use]` in 2018 idioms This commit adds a lint to the compiler to warn against the `#[macro_use]` directive as part of the `rust_2018_idioms` lint. This lint is turned off by default and is only enabled when the `use_extern_macros` feature is also enabled. The lint here isn't fully fleshed out as it's just a simple warning rather than suggestions of how to actually import the macro, but hopefully it's a good base to start from! cc #52043
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a lint to the compiler to warn against the
#[macro_use]directive as part of the
rust_2018_idiomslint. This lint is turned off bydefault and is only enabled when the
use_extern_macrosfeature is alsoenabled.
The lint here isn't fully fleshed out as it's just a simple warning rather than
suggestions of how to actually import the macro, but hopefully it's a good base
to start from!
cc #52043